linux-kernel - Re: [PATCH 8/9] regulator: palmas: add driver data and modularize the probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140617164502.GS29841@lee--X1>
Date:	Tue, 17 Jun 2014 17:45:02 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Keerthy <j-keerthy@...com>
Cc:	linux-omap@...r.kernel.org, lgirdwood@...il.com,
	broonie@...nel.org, linux-kernel@...r.kernel.org,
	sameo@...ux.intel.com
Subject: Re: [PATCH 8/9] regulator: palmas: add driver data and modularize
 the probe

> add driver data and modularize the probe.
> 
> Signed-off-by: Keerthy <j-keerthy@...com>
> ---
>  drivers/mfd/palmas.c                 |   42 +--
>  drivers/regulator/palmas-regulator.c |  656 ++++++++++++++++++++--------------
>  2 files changed, 395 insertions(+), 303 deletions(-)
> 
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c

[...]

> @@ -370,6 +334,8 @@ int palmas_ext_control_req_config(struct palmas *palmas,
>  	int bit_pos;
>  	int ret;
>  
> +	struct palmas_pmic_driver_data *pmic_ddata = palmas->pmic_ddata;
> +

Nit: I'd prefer the declarations to be grouped together, normally with
the struct defines above the ints etc.

[...]

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/