linux-kernel - Re: [PATCH 8/9] regulator: palmas: add driver data and modularize the probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A11B45.4010403@ti.com>
Date:	Wed, 18 Jun 2014 10:23:25 +0530
From:	Keerthy <a0393675@...com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Keerthy <j-keerthy@...com>, <linux-omap@...r.kernel.org>,
	<lgirdwood@...il.com>, <broonie@...nel.org>,
	<linux-kernel@...r.kernel.org>, <sameo@...ux.intel.com>
Subject: Re: [PATCH 8/9] regulator: palmas: add driver data and modularize
 the probe

On Tuesday 17 June 2014 10:15 PM, Lee Jones wrote:
>> add driver data and modularize the probe.
>>
>> Signed-off-by: Keerthy <j-keerthy@...com>
>> ---
>>   drivers/mfd/palmas.c                 |   42 +--
>>   drivers/regulator/palmas-regulator.c |  656 ++++++++++++++++++++--------------
>>   2 files changed, 395 insertions(+), 303 deletions(-)
>>
>> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> [...]
>
>> @@ -370,6 +334,8 @@ int palmas_ext_control_req_config(struct palmas *palmas,
>>   	int bit_pos;
>>   	int ret;
>>   
>> +	struct palmas_pmic_driver_data *pmic_ddata = palmas->pmic_ddata;
>> +
> Nit: I'd prefer the declarations to be grouped together, normally with
> the struct defines above the ints etc.

Ok. I will change this.

>
> [...]
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/