linux-kernel - Re: [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Jun 2014 09:59:37 +0200
From:	Helmut Schaa <helmut.schaa@...glemail.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ivo van Doorn <IvDoorn@...il.com>
Subject: Re: [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null
 test before kfree

Hi,

On Tue, Jun 17, 2014 at 9:36 PM, Fabian Frederick <fabf@...net.be> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required

Thanks Fabian.
This should go through the wireless tree I guess, mind to send to
linux-wireless@...r.kernel.org?
Helmut

> Cc: Ivo van Doorn <IvDoorn@...il.com>
> Cc: Helmut Schaa <helmut.schaa@...glemail.com>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 2bde672..c2c2300 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1452,8 +1452,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
>         /*
>          * Free the driver data.
>          */
> -       if (rt2x00dev->drv_data)
> -               kfree(rt2x00dev->drv_data);
> +       kfree(rt2x00dev->drv_data);
>  }
>  EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);
>
> --
> 1.8.4.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/