linux-kernel - Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140618080056.GM21030@lee--X1>
Date:	Wed, 18 Jun 2014 09:00:56 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	micky <micky_ching@...lsil.com.cn>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Chris Ball <chris@...ntf.net>, devel@...uxdriverproject.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Roger <rogerable@...ltek.com>, Wei WANG <wei_wang@...lsil.com.cn>
Subject: Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

On Mon, 16 Jun 2014, Ulf Hansson wrote:

> On 16 June 2014 14:20, Lee Jones <lee.jones@...aro.org> wrote:
> >> From: Micky Ching <micky_ching@...lsil.com.cn>
> >>
> >> rtsx driver using a single function for transfer data, dma map/unmap are
> >> placed in one fix function. We need map/unmap dma in different place(for
> >> mmc async driver), so add three function for dma map, dma transfer and
> >> dma unmap.
> >>
> >> Signed-off-by: Micky Ching <micky_ching@...lsil.com.cn>
> >> ---
> >>  drivers/mfd/rtsx_pcr.c       |   76 ++++++++++++++++++++++++++----------------
> >>  include/linux/mfd/rtsx_pci.h |    6 ++++
> >>  2 files changed, 54 insertions(+), 28 deletions(-)
> >
> > I don't see any glaring issues with this patch.  Does it rely on the
> > first patch, or vise versa, or can it just be applied?
> 
> The mmc part in patch2 relies on this one, but please go ahead and
> apply the mfd patch if you see it good.
> 
> I can later provide my ack for the mmc parts, in patch2, when it's a
> reviewed properly and thus you can take it through your tree.

There's no rush.  Once you're happy with the MMC patch, Micky can
submit them both again with my Ack on the MFD part and I'll take them
as a set.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/