linux-kernel - Re: [PATCH v4 1/7] mfd: axp20x: add AXP221 PMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A15202.1070908@free-electrons.com>
Date:	Wed, 18 Jun 2014 10:46:58 +0200
From:	Boris BREZILLON <boris.brezillon@...e-electrons.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Carlo Caione <carlo@...one.org>,
	Shuge <shuge@...winnertech.com>, kevin@...winnertech.com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	dev@...ux-sunxi.org
Subject: Re: [PATCH v4 1/7] mfd: axp20x: add AXP221 PMIC support


On 18/06/2014 10:36, Lee Jones wrote:
> On Tue, 17 Jun 2014, Boris BREZILLON wrote:
>
>> Add support for the AXP221 PMIC device to the existing AXP20x driver.
>>
>> The AXP221 defines a new set of registers, power supplies and regulators,
>> but most of the API is similar to the AXP20x ones.
>> The AXP20x irq chip definition is reused, though some interrupts are not
>> available in the AXP221.
>>
>> Signed-off-by: Boris BREZILLON <boris.brezillon@...e-electrons.com>
>> ---
>>  drivers/mfd/axp20x.c       | 64 ++++++++++++++++++++++++++++++++++++++++++----
>>  include/linux/mfd/axp20x.h | 56 ++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 115 insertions(+), 5 deletions(-)
> Looks good to me now.
>   Acked-by: Lee Jones <lee.jones@...aro.org>
>
> Can this go in independently to the other patches in the set?

Yes, as long as no one define an axp221 node in his DT.
In this case axp221 regulators would be considered as axp20x ones (which
might be a bit problematic), because axp20x-regulator driver does not
test the axp variant before probing its regulators (this test is
introduced in patch 3).

Best Regards,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/