linux-kernel - Re: [PATCH v2 06/10] mfd: Add driver for Maxim 77802 Power Management IC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Jun 2014 11:50:08 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Mark Brown <broonie@...nel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Mike Turquette <mturquette@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Daniel Stone <daniels@...labora.com>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 06/10] mfd: Add driver for Maxim 77802 Power Management
 IC

Hello Lee,

On 06/18/2014 10:32 AM, Lee Jones wrote:
>> >> +config MFD_MAX77802
>> >> +	tristate "Maxim Integrated MAX77802 PMIC Support"
>> >> +	depends on I2C=y
>> >> +	select MFD_CORE
>> >> +	select REGMAP_I2C
>> >> +	select REGMAP_IRQ
>> >> +	select IRQ_DOMAIN
>> >> +	help
>> >> +	  Say yes here to support for Maxim Integrated MAX77802.
>> >> +	  This is a Power Management IC with RTC on chip.
>> >> +	  This driver provides common support for accessing the device;
>> >> +	  additional drivers must be enabled in order to use the functionality
>> >> +	  of the device.
>> >> +
>> > 
>> > It is a bit unorthodox to put the build infrastructure in the same patch
>> > as the DT binding...
>> > 
>> 
>> I thought it was the opposite. That a DT binding document has to be added along
>> with the first user of the binding but I'll separate the DT doc in another patch
>> then if that is the right thing to do.
> 
> This was the 'old' method, but changed a little over a year ago.
> 
>> Thanks a lot for all your suggestions, I'll wait a little to see if there is
>> more feedback and repost a v3 addressing all the issues you pointed out.
> 
> Just re-post it.  I'll review the next version.
> 

Ok, will do. I was waiting for Krzysztof's feedback but he can review v3 as well.

Thanks a lot and best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/