[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140618095519.GE26461@leverpostej>
Date: Wed, 18 Jun 2014 10:55:19 +0100
From: Mark Rutland <mark.rutland@....com>
To: Varka Bhadram <varkabhadram@...il.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"alex.bluesman.smirnov@...il.com" <alex.bluesman.smirnov@...il.com>,
"dbaryshkov@...il.com" <dbaryshkov@...il.com>,
"linux-zigbee-devel@...ts.sourceforge.net"
<linux-zigbee-devel@...ts.sourceforge.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"davem@...emloft.net" <davem@...emloft.net>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Varka Bhadram <varkab@...c.in>
Subject: Re: [PATCH net-next v2 1/3] ieee802154: cc2520: adds driver for TI
CC2520 radio
On Wed, Jun 18, 2014 at 10:26:16AM +0100, Varka Bhadram wrote:
> +static int cc2520_probe(struct spi_device *spi)
> +{
> + struct cc2520_private *priv;
> + struct pinctrl *pinctrl;
> + struct cc2520_platform_data *pdata;
> + struct device_node __maybe_unused *np = spi->dev.of_node;
>
> This looks to be definitely unused rather than __maybe_unused. There are
> no other occuences of "np" in this function.
>
> This macro defined like this.
> #define __maybe_unused __attribute__((unused))
Sure, but that's irrelevant. There's absolutely no point in this
variable existing at all, and it can simply disappear.
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists