linux-kernel - Re: [PATCH v5 2/7] efi: Introduce EFI_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140618151232.GQ24049@console-pimps.org>
Date:	Wed, 18 Jun 2014 16:12:32 +0100
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
Cc:	Jan Beulich <JBeulich@...e.com>,
	Daniel Kiper <daniel.kiper@...cle.com>,
	andrew.cooper3@...rix.com, david.vrabel@...rix.com,
	ian.campbell@...rix.com, jeremy@...p.org, matt.fleming@...el.com,
	x86@...nel.org, tglx@...utronix.de, xen-devel@...ts.xenproject.org,
	boris.ostrovsky@...cle.com, konrad.wilk@...cle.com,
	eshelton@...ox.com, mingo@...hat.com, mjg59@...f.ucam.org,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	hpa@...or.com
Subject: Re: [PATCH v5 2/7] efi: Introduce EFI_NO_DIRECT flag

On Wed, 18 Jun, at 03:30:25PM, Stefano Stabellini wrote:
> 
> I was thinking the same thing.
> 
> However this patch series doesn't add much code outside
> drivers/xen/efi.c and include/xen/interface/platform.h.
> I think it wouldn't be fair to ask Daniel to refactor the efi code
> currently under arch/x86 to an arch-independent location.
> Whoever comes in later and adds EFI Xen support for ARM can do that.

I agree that we shouldn't necessarily build tons of arch-independent
infrastructure when there's only one user, but it is wise to be careful
about the design decisions being made if you know there's another user
coming around the corner.

What we don't want to happen, is for the designs that we have now to
become set in stone such that they can never be changed, to the
deteriment of code duplication and maintenance.

I don't think that's happening in this patch series, but it's definitely
smart discussing this stuff upfront.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/