linux-kernel - Re: [PATCH] floppy: Neaten message logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1406182358320.2303@pobox.suse.cz>
Date:	Wed, 18 Jun 2014 23:59:29 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Joe Perches <joe@...ches.com>
cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] floppy: Neaten message logging

On Wed, 18 Jun 2014, Joe Perches wrote:

> Use a more current style to prefix "floppy: " on
> all messages.
> 
> Convert DPRINT to emit at KERN_DEBUG.
> 
> Other miscellaneous logging changes:
> 
> o Add missing newline
> o Remove embedded "floppy" style prefixes

Why is this a good change?

[ ... ]
>  	if (!req) {
> -		pr_info("floppy.c: no request in request_done\n");
> +		pr_info("no request in request_done\n");

I think that in cases like this (and elsewhere where you are changing it 
in your patch) the prefix is actually useful.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/