linux-kernel - Re: [PATCH] floppy: Neaten message logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1403129350.14018.1.camel@joe-AO725>
Date:	Wed, 18 Jun 2014 15:09:10 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] floppy: Neaten message logging

On Wed, 2014-06-18 at 23:59 +0200, Jiri Kosina wrote:
> On Wed, 18 Jun 2014, Joe Perches wrote:
> 
> > Use a more current style to prefix "floppy: " on
> > all messages.
> > 
> > Convert DPRINT to emit at KERN_DEBUG.
> > 
> > Other miscellaneous logging changes:
> > 
> > o Add missing newline
> > o Remove embedded "floppy" style prefixes
> 
> Why is this a good change?
> 
> [ ... ]
> >  	if (!req) {
> > -		pr_info("floppy.c: no request in request_done\n");
> > +		pr_info("no request in request_done\n");
> 
> I think that in cases like this (and elsewhere where you are changing it 
> in your patch) the prefix is actually useful.

Adding

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

makes sure that all printks from this module
are prefixed with "floppy: ".

Currently, only a very few actually are prefixed
with anything and there are some prefix mixtures of
"floppy: " and "floppy.c: "




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/