linux-kernel - Re: [PATCH] Fixes no Null check of dev_skb_alloc in fw_download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140618221332.GA8693@kroah.com>
Date:	Wed, 18 Jun 2014 15:13:32 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	devel@...verdev.osuosl.org, lisa@...apiadmin.com,
	ben@...adent.org.uk, valentina.manea.m@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code

On Wed, Jun 18, 2014 at 05:26:18PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 ++++
>  1 file changed, 4 insertions(+)

Some more meta-comments.  Your subject: should give people a clue as to
where in the kernel you are changing.  This patch would be:
	Subject: staging: rtl8192e: check return value of dev_skb_alloc

And then in the body of the patch changelog area, explain why you are
doing this.

> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 1a95d1f..1a90546 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> @@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
>  		}
>  
>  		skb  = dev_alloc_skb(frag_length + 4);
> +		if (!skb) {
> +			rt_status = false;
> +			return rt_status;
> +		}

Does that really look like the correct thing to be doing here?  Surely
you can delete 2 lines of this patch, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/