linux-kernel - Re: drivers/acpi/ac.c, re-enabling CONFIG_ACPI_PROCFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53A34031.4030004@gmail.com>
Date:	Thu, 19 Jun 2014 21:55:29 +0200
From:	Sorin Manolache <sorinm@...il.com>
To:	Lan Tianyu <tianyu.lan@...el.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>
CC:	Zhang Rui <rui.zhang@...el.com>, linux-kernel@...r.kernel.org,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: drivers/acpi/ac.c, re-enabling CONFIG_ACPI_PROCFS_POWER?

On 2014-06-19 09:47, Lan Tianyu wrote:
> On 2014年06月19日 14:32, Lan Tianyu wrote:
>> On 2014年06月19日 07:17, Rafael J. Wysocki wrote:
>>> On Wednesday, June 18, 2014 10:28:12 PM Sorin Manolache wrote:
>>>> Hello,
>>>>
>>>> Would it be worth considering re-enabling the old procfs interface for
>>>> ac.c? There are old tools still around (kpowersave from kde 3.5.10) that
>>>> expect /proc/acpi/ac_adapter.
>>>
>>> Can you please CC ACPI-related messages to linux-acpi@...r.kernel.org?
>>>
>>> I'm not sure how much effort that would require at this point.  Rui, Tianyu?
>>
>> I think we need to revert commit ab0fd67.
>>
>> commit ab0fd674d6cef0904baa511f22613ef6474f8169
>> Author: Lan Tianyu <tianyu.lan@...el.com>
>> Date:   Sat Oct 12 21:04:48 2013 +0800
>>
>>      ACPI / AC: Remove AC's proc directory.
>>
>>      AC's proc directory is not used and so remove it. Prepare for removing
>>      /proc/acpi directory.
>>
>>      Signed-off-by: Lan Tianyu <tianyu.lan@...el.com>
>>      Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>>
>
> Hi Sorin:
> 	Please try the patch in the attachment.
>

Hello Tianyu,

I've applied the patch to 3.15.1. The code did not compile because of 
ac->adev in acpi_ac_add_fs and acpi_ac_remove_fs. The acpi_ac structure 
contains a field "device" and not "adev". So I've modified the patch and 
I've attached it.

Now it works.

Thank you,
Sorin







>>
>>>
>>> Rafael
>>>
>>
>>
>
>



View attachment "0001-Revert-ACPI-AC-Remove-AC-s-proc-directory.patch" of type "text/x-diff" (6151 bytes)