lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Jun 2014 13:01:59 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: Daniel Vetter <daniel@...ll.ch> Cc: Rob Clark <robdclark@...il.com>, Maarten Lankhorst <maarten.lankhorst@...onical.com>, linux-arch@...r.kernel.org, Thomas Hellstrom <thellstrom@...are.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>, Thierry Reding <thierry.reding@...il.com>, Colin Cross <ccross@...gle.com>, Sumit Semwal <sumit.semwal@...aro.org>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org> Subject: Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17) On Thu, Jun 19, 2014 at 09:15:36PM +0200, Daniel Vetter wrote: > On Thu, Jun 19, 2014 at 7:00 PM, Greg KH <gregkh@...uxfoundation.org> wrote: > >> >> + BUG_ON(f1->context != f2->context); > >> > > >> > Nice, you just crashed the kernel, making it impossible to debug or > >> > recover :( > >> > >> agreed, that should probably be 'if (WARN_ON(...)) return NULL;' > >> > >> (but at least I wouldn't expect to hit that under console_lock so you > >> should at least see the last N lines of the backtrace on the screen > >> ;-)) > > > > Lots of devices don't have console screens :) > > Aside: This is a pet peeve of mine and recently I've switched to > rejecting all patch that have a BUG_ON, period. Please do, I have been for a few years now as well for the same reasons you cite. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists