linux-kernel - Re: [PATCH 3/8] wlan-ng/prism2mgmt:checkpatch: Insert blank line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140619201140.GB16404@cloud>
Date:	Thu, 19 Jun 2014 13:11:40 -0700
From:	josh@...htriplett.org
To:	Johannes Stadlinger <Johannes.Stadlinger@....de>
Cc:	devel@...uxdriverproject.org,
	Maximilian Eschenbacher <maximilian@...henbacher.email>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Himangi Saraogi <himangi774@...il.com>,
	Vitaly Osipov <vitaly.osipov@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] wlan-ng/prism2mgmt:checkpatch: Insert blank line

On Thu, Jun 19, 2014 at 09:20:15PM +0200, Johannes Stadlinger wrote:
> This patch inserts a blank line after a declaration to avoid checkpatch
> warning.
> 
> Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@....de>
> Signed-off-by: Maximilian Eschenbacher <maximilian@...henbacher.email>
> CC: linux-kernel@...cs.fau.de
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Josh Triplett <josh@...htriplett.org>
> CC: Himangi Saraogi <himangi774@...il.com>
> CC: Vitaly Osipov <vitaly.osipov@...il.com>
> CC: devel@...verdev.osuosl.org
> CC: linux-kernel@...r.kernel.org

This is one case where I think checkpatch is just wrong; this doesn't
make the code any more (or less) readable.

Meh-by: Josh Triplett <josh@...htriplett.org>

>  drivers/staging/wlan-ng/prism2mgmt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index f90f7da..e6a82d3 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -190,6 +190,7 @@ int prism2mgmt_scan(wlandevice_t *wlandev, void *msgp)
>  	word = 0;
>  	for (i = 0; i < msg->channellist.data.len; i++) {
>  		u8 channel = msg->channellist.data.data[i];
> +
>  		if (channel > 14)
>  			continue;
>  		/* channel 1 is BIT 0 ... channel 14 is BIT 13 */
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/