lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 19 Jun 2014 13:09:47 -0700
From:	josh@...htriplett.org
To:	Johannes Stadlinger <Johannes.Stadlinger@....de>
Cc:	devel@...uxdriverproject.org,
	Maximilian Eschenbacher <maximilian@...henbacher.email>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Himangi Saraogi <himangi774@...il.com>,
	Vitaly Osipov <vitaly.osipov@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] wlan-ng/prism2mgmt:checkpatch: Fix string split

On Thu, Jun 19, 2014 at 09:20:14PM +0200, Johannes Stadlinger wrote:
> This patch fixes all warnings of checkpatch about string splitting.
> 
> Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@....de>
> Signed-off-by: Maximilian Eschenbacher <maximilian@...henbacher.email>
> CC: linux-kernel@...cs.fau.de
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Himangi Saraogi <himangi774@...il.com>
> CC: Josh Triplett <josh@...htriplett.org>
> CC: Vitaly Osipov <vitaly.osipov@...il.com>
> CC: devel@...verdev.osuosl.org
> CC: linux-kernel@...r.kernel.org

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/staging/wlan-ng/prism2mgmt.c | 26 ++++++++++----------------
>  1 file changed, 10 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 36a3e1a..f90f7da 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -178,8 +178,7 @@ int prism2mgmt_scan(wlandevice_t *wlandev, void *msgp)
>  					     word);
>  		if (result) {
>  			netdev_warn(wlandev->netdev,
> -				    "Passive scan not supported with "
> -				    "current firmware.  (<1.5.1)\n");
> +				    "Passive scan not supported with current firmware.  (<1.5.1)\n");
>  		}
>  	}
>  
> @@ -381,8 +380,7 @@ int prism2mgmt_scan_results(wlandevice_t *wlandev, void *msgp)
>  
>  	if (!hw->scanresults) {
>  		netdev_err(wlandev->netdev,
> -			   "dot11req_scan_results can only be used after "
> -			   "a successful dot11req_scan.\n");
> +			   "dot11req_scan_results can only be used after a successful dot11req_scan.\n");
>  		result = 2;
>  		req->resultcode.data = P80211ENUM_resultcode_invalid_parameters;
>  		goto exit;
> @@ -733,8 +731,8 @@ int prism2mgmt_readpda(wlandevice_t *wlandev, void *msgp)
>  					      HFA384x_PDA_LEN_MAX);
>  		if (result) {
>  			netdev_err(wlandev->netdev,
> -				   "hfa384x_drvr_readpda() failed, "
> -				   "result=%d\n", result);
> +				   "hfa384x_drvr_readpda() failed, result=%d\n",
> +				   result);
>  
>  			msg->resultcode.data =
>  			    P80211ENUM_resultcode_implementation_failure;
> @@ -782,8 +780,7 @@ int prism2mgmt_ramdl_state(wlandevice_t *wlandev, void *msgp)
>  
>  	if (wlandev->msdstate != WLAN_MSD_FWLOAD) {
>  		netdev_err(wlandev->netdev,
> -			   "ramdl_state(): may only be called "
> -			   "in the fwload state.\n");
> +			   "ramdl_state(): may only be called in the fwload state.\n");
>  		msg->resultcode.data =
>  		    P80211ENUM_resultcode_implementation_failure;
>  		msg->resultcode.status = P80211ENUM_msgitem_status_data_ok;
> @@ -841,8 +838,7 @@ int prism2mgmt_ramdl_write(wlandevice_t *wlandev, void *msgp)
>  
>  	if (wlandev->msdstate != WLAN_MSD_FWLOAD) {
>  		netdev_err(wlandev->netdev,
> -			   "ramdl_write(): may only be called "
> -			   "in the fwload state.\n");
> +			   "ramdl_write(): may only be called in the fwload state.\n");
>  		msg->resultcode.data =
>  		    P80211ENUM_resultcode_implementation_failure;
>  		msg->resultcode.status = P80211ENUM_msgitem_status_data_ok;
> @@ -901,8 +897,7 @@ int prism2mgmt_flashdl_state(wlandevice_t *wlandev, void *msgp)
>  
>  	if (wlandev->msdstate != WLAN_MSD_FWLOAD) {
>  		netdev_err(wlandev->netdev,
> -			   "flashdl_state(): may only be called "
> -			   "in the fwload state.\n");
> +			   "flashdl_state(): may only be called in the fwload state.\n");
>  		msg->resultcode.data =
>  		    P80211ENUM_resultcode_implementation_failure;
>  		msg->resultcode.status = P80211ENUM_msgitem_status_data_ok;
> @@ -936,8 +931,8 @@ int prism2mgmt_flashdl_state(wlandevice_t *wlandev, void *msgp)
>  		result = prism2sta_ifstate(wlandev, P80211ENUM_ifstate_fwload);
>  		if (result != P80211ENUM_resultcode_success) {
>  			netdev_err(wlandev->netdev,
> -				   "prism2sta_ifstate(fwload) failed,"
> -				   "P80211ENUM_resultcode=%d\n", result);
> +				   "prism2sta_ifstate(fwload) failed, P80211ENUM_resultcode=%d\n",
> +				   result);
>  			msg->resultcode.data =
>  			    P80211ENUM_resultcode_implementation_failure;
>  			result = -1;
> @@ -975,8 +970,7 @@ int prism2mgmt_flashdl_write(wlandevice_t *wlandev, void *msgp)
>  
>  	if (wlandev->msdstate != WLAN_MSD_FWLOAD) {
>  		netdev_err(wlandev->netdev,
> -			   "flashdl_write(): may only be called "
> -			   "in the fwload state.\n");
> +			   "flashdl_write(): may only be called in the fwload state.\n");
>  		msg->resultcode.data =
>  		    P80211ENUM_resultcode_implementation_failure;
>  		msg->resultcode.status = P80211ENUM_msgitem_status_data_ok;
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists