linux-kernel - Re: [PATCH 8/8] wlan-ng/prism2sta:checkpatch: Insert blank lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140619202044.GH16404@cloud>
Date:	Thu, 19 Jun 2014 13:20:44 -0700
From:	josh@...htriplett.org
To:	Johannes Stadlinger <Johannes.Stadlinger@....de>
Cc:	devel@...uxdriverproject.org,
	Maximilian Eschenbacher <maximilian@...henbacher.email>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tugce Sirin <ztugcesirin@...il.com>,
	Himangi Saraogi <himangi774@...il.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Vitaly Osipov <vitaly.osipov@...il.com>,
	Neil Armstrong <superna9999@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] wlan-ng/prism2sta:checkpatch: Insert blank lines

On Thu, Jun 19, 2014 at 09:20:20PM +0200, Johannes Stadlinger wrote:
> This patch inserts blank lines after declarations to avoid checkpatch
> warnings.
> 
> After our fixes in 'wlan-ng/prism2sta' there is still a checkpatch
> warning about prefering 'ether_addr_copy' instead of 'memcpy'
> remaining.
> 
> Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@....de>
> Signed-off-by: Maximilian Eschenbacher <maximilian@...henbacher.email>
> CC: linux-kernel@...cs.fau.de
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Tugce Sirin <ztugcesirin@...il.com>
> CC: Josh Triplett <josh@...htriplett.org>
> CC: Himangi Saraogi <himangi774@...il.com>
> CC: Paul Gortmaker <paul.gortmaker@...driver.com>
> CC: Vitaly Osipov <vitaly.osipov@...il.com>
> CC: Neil Armstrong <superna9999@...il.com>
> CC: devel@...verdev.osuosl.org
> CC: linux-kernel@...r.kernel.org

This one does look like an improvement.

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/staging/wlan-ng/prism2sta.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
> index 9444006..8d4d7ba 100644
> --- a/drivers/staging/wlan-ng/prism2sta.c
> +++ b/drivers/staging/wlan-ng/prism2sta.c
> @@ -360,6 +360,7 @@ static int prism2sta_mlmerequest(wlandevice_t *wlandev, struct p80211msg *msg)
>  	case DIDmsg_lnxreq_ifstate:
>  		{
>  			struct p80211msg_lnxreq_ifstate *ifstatemsg;
> +
>  			pr_debug("Received mlme ifstate request\n");
>  			ifstatemsg = (struct p80211msg_lnxreq_ifstate *) msg;
>  			result =
> @@ -1411,6 +1412,7 @@ void prism2sta_processing_defer(struct work_struct *data)
>  		 */
>  		if (hw->join_ap && --hw->join_retries > 0) {
>  			hfa384x_JoinRequest_data_t joinreq;
> +
>  			joinreq = hw->joinreq;
>  			/* Send the join request */
>  			hfa384x_drvr_setconfig(hw,
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/