linux-kernel - Re: [PATCH 3/8] wlan-ng/prism2mgmt:checkpatch: Insert blank line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2014 11:14:23 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	josh@...htriplett.org
Cc:	Johannes Stadlinger <Johannes.Stadlinger@....de>,
	devel@...verdev.osuosl.org,
	Maximilian Eschenbacher <maximilian@...henbacher.email>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org,
	Himangi Saraogi <himangi774@...il.com>,
	devel@...uxdriverproject.org
Subject: Re: [PATCH 3/8] wlan-ng/prism2mgmt:checkpatch: Insert blank line

On Thu, Jun 19, 2014 at 01:11:40PM -0700, josh@...htriplett.org wrote:
> On Thu, Jun 19, 2014 at 09:20:15PM +0200, Johannes Stadlinger wrote:
> > This patch inserts a blank line after a declaration to avoid checkpatch
> > warning.
> > 
> > Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@....de>
> > Signed-off-by: Maximilian Eschenbacher <maximilian@...henbacher.email>
> > CC: linux-kernel@...cs.fau.de
> > CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > CC: Josh Triplett <josh@...htriplett.org>
> > CC: Himangi Saraogi <himangi774@...il.com>
> > CC: Vitaly Osipov <vitaly.osipov@...il.com>
> > CC: devel@...verdev.osuosl.org
> > CC: linux-kernel@...r.kernel.org
> 
> This is one case where I think checkpatch is just wrong; this doesn't
> make the code any more (or less) readable.
> 
> Meh-by: Josh Triplett <josh@...htriplett.org>

We've asked about making checkpatch ignore small blocks but apparently
that is a hard thing.  It's less work to apply these than to argue about
them and adding a space doesn't hurt so meh is correct.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/