linux-kernel - Re: [PATCH 5/8] wlan-ng/prism2mib:checkpatch: Insert blank lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Jun 2014 13:25:18 -0700
From:	Joe Perches <joe@...ches.com>
To:	josh@...htriplett.org
Cc:	Johannes Stadlinger <Johannes.Stadlinger@....de>,
	devel@...uxdriverproject.org,
	Maximilian Eschenbacher <maximilian@...henbacher.email>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Vitaly Osipov <vitaly.osipov@...il.com>,
	Himangi Saraogi <himangi774@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] wlan-ng/prism2mib:checkpatch: Insert blank lines

On Thu, 2014-06-19 at 13:14 -0700, josh@...htriplett.org wrote:
> On Thu, Jun 19, 2014 at 09:20:17PM +0200, Johannes Stadlinger wrote:
> > This patch inserts blank lines after declarations to avoid checkpatch
> > warning.
[]
> > diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
[]
> > @@ -85,7 +85,8 @@ struct mibrec {
> >  	u16 parm1;
> >  	u16 parm2;
> >  	u16 parm3;
> > -	int (*func) (struct mibrec *mib,
> > +
> > +	int (*func)(struct mibrec *mib,
> 
> Eliminating the space here makes sense, but checkpatch shouldn't warn
> about spaces after declarations between two fields in the middle of a
> structure declaration.

It's a defect in checkpatch,
It's fixed in the latest version in -next

https://lkml.org/lkml/2014/6/6/426


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/