lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Jun 2014 12:46:33 +0200 From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Larry Finger <Larry.Finger@...inger.net>, Florian Schilhabel <florian.c.schilhabel@...glemail.com>, devel@...verdev.osuosl.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Paul Gortmaker <paul.gortmaker@...driver.com>, Thomas Cort <linuxgeek@...il.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Subject: Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement Hi It's a bit confusing with this, I have received a lot of complaints that I have not had a cover letter. When should I include it? In an obvious patching. But where there's a need to explain anything further should have a cover letter. In this case, I suspected that there is a missed special case, that I mentioned in the cover letter. But did my patch that otherwise took away the otherwise unnecessary code. Thought it was the right use...? Kind regards Rickard Strandqvist 2014-06-16 11:05 GMT+02:00 Dan Carpenter <dan.carpenter@...cle.com>: > On Sun, Jun 15, 2014 at 07:20:57PM +0200, Rickard Strandqvist wrote: >> The same code regardless of the outcome of the if statement. This may of >> course be a miss and there should be a difference in the code. >> And clean up another duplicate line of code. >> >> This was partly found using a static code analysis program called cppcheck. >> > > We don't need a cover letter for a single patch. Just put this stuff in > the patch description next time. > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists