linux-kernel - Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140620105903.GT5500@mwanda>
Date:	Fri, 20 Jun 2014 13:59:03 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	devel@...verdev.osuosl.org,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Thomas Cort <linuxgeek@...il.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up
 useless if statement

On Fri, Jun 20, 2014 at 12:46:33PM +0200, Rickard Strandqvist wrote:
> Hi
> 
> It's a bit confusing with this, I have received a lot of complaints
> that I have not had a cover letter.
> When should I include it? In an obvious patching. But where there's a
> need to explain anything further should have a cover letter.

Cover letters are for if you have a series of patches and they follow a
theme.  "Add support for XXX feature in a series of 8 patches".  "What
is in my pull request for the new kernel."  It's just a shorter summary.
This is just one patch not a series.

I have never sent a cover letter in my life.  I don't know who is
complaining to you...

In this case the changelog would have been better and more complete if
all the cover letter information were in the permanent commit log.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/