linux-kernel - Re: [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A499B8.5050107@fb.com>
Date:	Fri, 20 Jun 2014 13:29:44 -0700
From:	Josef Bacik <jbacik@...com>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Chris Mason <clm@...com>, Jiri Kosina <trivial@...nel.org>
CC:	<linux-btrfs@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed
 by if

On 06/20/2014 12:51 PM, Rasmus Villemoes wrote:
> Maybe "else if" was meant, but because of the goto out_unlock, it
> doesn't make a difference. Anyway, I chose the "only whitespace" fix.
>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>   fs/btrfs/tree-log.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> index 9e1f2cd..50af2b9 100644
> --- a/fs/btrfs/tree-log.c
> +++ b/fs/btrfs/tree-log.c
> @@ -3980,7 +3980,8 @@ again:
>   		if (ret < 0) {
>   			err = ret;
>   			goto out_unlock;
> -		} if (ret) {
> +		}
> +		if (ret) {
>   			ins_nr = 0;
>   			btrfs_release_path(path);
>   			continue;
>

Nope that's right, thanks,

Reviewed-by: Josef Bacik <jbacik@...com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/