linux-kernel - Re: [PATCH 1/3] staging: vt6655: update out-of-date function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140620203118.GA13042@xps>
Date:	Fri, 20 Jun 2014 16:31:18 -0400
From:	"James A. Shackleford" <shack@...ux.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	forest@...ttletooquiet.net, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: vt6655: update out-of-date function
 declaration

On Thu, Jun 19, 2014 at 04:35:02PM -0700, Greg KH wrote:
> On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote:
> > The function iwctl_siwscan() is defined in iwctl.c as:
> > int iwctl_siwscan(struct net_device *dev,
> > 		  struct iw_request_info *info,
> > 		  struct iw_point *wrq,
> > 		  char *extra)
> > {
> >   ...
> > 
> > This patch updates iwctl.h so that the type of the 3rd parameter (*wqr) in the
> > function declaration matches the definition.
> > 
> > Signed-off-by: James A Shackleford <shack@...ux.com>
> > ---
> >  drivers/staging/vt6655/iwctl.h |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h
> > index 871bd7c..4ad5e48 100644
> > --- a/drivers/staging/vt6655/iwctl.h
> > +++ b/drivers/staging/vt6655/iwctl.h
> > @@ -168,7 +168,7 @@ int iwctl_giwscan(struct net_device *dev,
> >  
> >  int iwctl_siwscan(struct net_device *dev,
> >  		  struct iw_request_info *info,
> > -		  struct iw_param *wrq,
> > +		  struct iw_point *wrq,
> >  		  char *extra);
> >  
> 
> Why isn't the compiler catching this issue?  Should something include
> this .h file?
> 
> thanks,
> 
> greg k-h

The declaration for iwctl_siwscan(), along with quite a few other declarations,
should be removed from this header and their functions made static within
iwctl.c  I will put another patch together that further cleans this up.
 
-James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/