linux-kernel - Re: [PATCH 1/2] ASoC: max98090: Add max98091 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=XX1XAX-jZTJaQYTHbeXkHu2uX_6==vHYbSnVpjJe6+tQ@mail.gmail.com>
Date:	Fri, 20 Jun 2014 13:32:26 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Tushar Behera <tushar.b@...sung.com>
Cc:	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	alsa-devel@...a-project.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Kukjin Kim <kgene.kim@...sung.com>, tiwai@...e.de,
	"broonie@...nel.org" <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Kumar Gala <galak@...eaurora.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Tushar Behera <trblinux@...il.com>,
	Wonjoon Lee <woojoo.lee@...sung.com>
Subject: Re: [PATCH 1/2] ASoC: max98090: Add max98091 compatible string

Tushar,

On Fri, Jun 20, 2014 at 1:03 AM, Tushar Behera <tushar.b@...sung.com> wrote:
> From: Wonjoon Lee <woojoo.lee@...sung.com>
>
> The MAX98091 CODEC is the same as MAX98090 CODEC, but with an extra
> microphone. Existing driver for MAX98090 CODEC already has support
> for MAX98091 CODEC. Adding proper compatible string so that MAX98091
> CODEC can be specified from device tree.
>
> Signed-off-by: Wonjoon Lee <woojoo.lee@...sung.com>
> Signed-off-by: Doug Anderson <dianders@...omium.org>
> Signed-off-by: Tushar Behera <tushar.b@...sung.com>
> ---
>
> Picked from https://chromium-review.googlesource.com/#/c/184091/
>
>  .../devicetree/bindings/sound/max98090.txt         |    2 +-
>  sound/soc/codecs/max98090.c                        |    2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/max98090.txt b/Documentation/devicetree/bindings/sound/max98090.txt
> index a5e63fa..c454e67 100644
> --- a/Documentation/devicetree/bindings/sound/max98090.txt
> +++ b/Documentation/devicetree/bindings/sound/max98090.txt
> @@ -4,7 +4,7 @@ This device supports I2C only.
>
>  Required properties:
>
> -- compatible : "maxim,max98090".
> +- compatible : "maxim,max98090" or "maxim,max98091".
>
>  - reg : The I2C address of the device.
>
> diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
> index f5fccc7..4f5534d 100644
> --- a/sound/soc/codecs/max98090.c
> +++ b/sound/soc/codecs/max98090.c
> @@ -2460,12 +2460,14 @@ static const struct dev_pm_ops max98090_pm = {
>
>  static const struct i2c_device_id max98090_i2c_id[] = {
>         { "max98090", MAX98090 },
> +       { "max98091", MAX98091 },

optional: This would allow you to add some extra error checking in
max98090_probe() to make sure that the device-tree specified device
matched the device that was detected.  That could be in a future
patch, though.

Reviewed-by: Doug Anderson <dianders@...omium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/