linux-kernel - Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPnjgZ2_T46YgQnS1WvG7Wf8oPREuZmayE+_JkTzuEUVtAA=OA@mail.gmail.com>
Date:	Tue, 24 Jun 2014 09:53:17 -0600
From:	Simon Glass <sjg@...omium.org>
To:	Doug Anderson <dianders@...omium.org>
Cc:	Wolfram Sang <wsa@...-dreams.de>, Lee Jones <lee.jones@...aro.org>,
	Dave Jones <davej@...hat.com>,
	Randall Spangler <rspangler@...omium.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Bill Richardson <wfrichar@...omium.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	lk <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG_10BIT

On 23 June 2014 15:20, Doug Anderson <dianders@...omium.org> wrote:
> In <https://lkml.org/lkml/2014/6/10/265> pointed out that the 10-bit
> flag in the cros_ec_tunnel was useless.  It went into a 16-bit flags
> field but was defined at (1 << 16).
>
> Since we have no 10-bit i2c devices on the other side of the tunnel on
> any known devices this was never a problem.  Until we do it makes
> sense to remove this code.  On the EC side the code to handle this
> flag was removed in <https://chromium-review.googlesource.com/204162>.
>
> Reported-by: Dave Jones <davej@...hat.com>
> Signed-off-by: Doug Anderson <dianders@...omium.org>

Funny. We certainly don't use it.

Reviewed-by: Simon Glass <sjg@...omium.org>

Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/