linux-kernel - Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Jun 2014 14:34:43 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Doug Anderson <dianders@...omium.org>
Cc:	Lee Jones <lee.jones@...aro.org>, Dave Jones <davej@...hat.com>,
	rspangler@...omium.org, sjg@...omium.org, sameo@...ux.intel.com,
	wfrichar@...omium.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG_10BIT

On Mon, Jun 23, 2014 at 02:20:06PM -0700, Doug Anderson wrote:
> In <https://lkml.org/lkml/2014/6/10/265> pointed out that the 10-bit
> flag in the cros_ec_tunnel was useless.  It went into a 16-bit flags
> field but was defined at (1 << 16).
> 
> Since we have no 10-bit i2c devices on the other side of the tunnel on
> any known devices this was never a problem.  Until we do it makes
> sense to remove this code.  On the EC side the code to handle this
> flag was removed in <https://chromium-review.googlesource.com/204162>.
> 
> Reported-by: Dave Jones <davej@...hat.com>
> Signed-off-by: Doug Anderson <dianders@...omium.org>
> ---
> Note that this patch is based atop my current series of posts to
> cleanup cros_ec.  It wouldn't be hard to apply it to the current ToT
> if someone wants to land this before the others.

I could take it into my tree, but I think it makes more sense if we
simply append it to your cleanup series?

Reviewed-by: Wolfram Sang <wsa@...-dreams.de>


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)