linux-kernel - Re: [PATCH] perf: fix arm64 build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Jun 2014 10:12:33 +0200
From:	Jean Pihet <jean.pihet@...aro.org>
To:	Mark Salter <msalter@...hat.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH] perf: fix arm64 build error

Hi Mark,

On 25 June 2014 05:16, Mark Salter <msalter@...hat.com> wrote:
> I'm seeing the following build error on arm64:
>
>   In file included from util/event.c:3:0:
>   util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)
>     u64 cache_regs[PERF_REGS_MAX];
>                  ^
>
> This patch adds a PEFF_REGS_MAX definition for arm64.
s/PEFF_REGS_MAX/PERF_REGS_MAX

>
> Signed-off-by: Mark Salter <msalter@...hat.com>

Acked-by: Jean Pihet <jean.pihet@...aro.org>

Thanks!

Note: Do you have any performance figure with and without the caching
code in perf?

Jean

> ---
>  tools/perf/arch/arm64/include/perf_regs.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/arch/arm64/include/perf_regs.h b/tools/perf/arch/arm64/include/perf_regs.h
> index e9441b9..1d3f39c 100644
> --- a/tools/perf/arch/arm64/include/perf_regs.h
> +++ b/tools/perf/arch/arm64/include/perf_regs.h
> @@ -6,6 +6,8 @@
>  #include <asm/perf_regs.h>
>
>  #define PERF_REGS_MASK ((1ULL << PERF_REG_ARM64_MAX) - 1)
> +#define PERF_REGS_MAX  PERF_REG_ARM64_MAX
> +
>  #define PERF_REG_IP    PERF_REG_ARM64_PC
>  #define PERF_REG_SP    PERF_REG_ARM64_SP
>
> --
> 1.9.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/