lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Jun 2014 16:03:12 +0200 From: Oleg Nesterov <oleg@...hat.com> To: Kees Cook <keescook@...omium.org> Cc: linux-kernel@...r.kernel.org, Andy Lutomirski <luto@...capital.net>, "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>, Alexei Starovoitov <ast@...mgrid.com>, Andrew Morton <akpm@...ux-foundation.org>, Daniel Borkmann <dborkman@...hat.com>, Will Drewry <wad@...omium.org>, Julien Tinnes <jln@...omium.org>, David Drysdale <drysdale@...gle.com>, linux-api@...r.kernel.org, x86@...nel.org, linux-arm-kernel@...ts.infradead.org, linux-mips@...ux-mips.org, linux-arch@...r.kernel.org, linux-security-module@...r.kernel.org Subject: Re: [PATCH v8 3/9] seccomp: introduce writer locking On 06/24, Kees Cook wrote: > > @@ -524,6 +529,8 @@ static long seccomp_set_mode(unsigned long seccomp_mode, char __user *filter) > } > #endif > > + spin_lock_irqsave(¤t->sighand->siglock, irqflags); > + Well, I won't argue if you prefer to use _irqsave "just in case". But irqs must be enabled in syscall paths, you could use spin_lock_irq(). The same for seccomp_set_mode_filter() added later. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists