linux-kernel - Re: [PATCH 1/6] percpu-refcount, aio: use percpu_ref_cancel_init() in ioctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140625143112.GR23137@kvack.org>
Date:	Wed, 25 Jun 2014 10:31:12 -0400
From:	Benjamin LaHaise <bcrl@...ck.org>
To:	Tejun Heo <tj@...nel.org>
Cc:	cl@...ux-foundation.org, kmo@...erainc.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] percpu-refcount, aio: use percpu_ref_cancel_init() in ioctx_alloc()

On Tue, Jun 17, 2014 at 09:08:00PM -0400, Tejun Heo wrote:
> ioctx_alloc() reaches inside percpu_ref and directly frees
> ->pcpu_count in its failure path, which is quite gross.  percpu_ref
> has been providing a proper interface to do this,
> percpu_ref_cancel_init(), for quite some time now.  Let's use that
> instead.

I applied this to my aio-next tree at git://git.kvack.org/~bcrl/aio-next.git .

		-ben

> This patch doesn't introduce any behavior changes.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Benjamin LaHaise <bcrl@...ck.org>
> Cc: Kent Overstreet <kmo@...erainc.com>
> ---
>  fs/aio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/aio.c b/fs/aio.c
> index 4f078c0..5e0d7f9 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -715,8 +715,8 @@ err_ctx:
>  err:
>  	mutex_unlock(&ctx->ring_lock);
>  	free_percpu(ctx->cpu);
> -	free_percpu(ctx->reqs.pcpu_count);
> -	free_percpu(ctx->users.pcpu_count);
> +	percpu_ref_cancel_init(&ctx->reqs);
> +	percpu_ref_cancel_init(&ctx->users);
>  	kmem_cache_free(kioctx_cachep, ctx);
>  	pr_debug("error allocating ioctx %d\n", err);
>  	return ERR_PTR(err);
> -- 
> 1.9.3

-- 
"Thought is the essence of where you are now."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/