linux-kernel - Re: [PATCH 1/6] percpu-refcount, aio: use percpu_ref_cancel_init() in ioctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140625145634.GD26883@htj.dyndns.org>
Date:	Wed, 25 Jun 2014 10:56:34 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Benjamin LaHaise <bcrl@...ck.org>
Cc:	cl@...ux-foundation.org, kmo@...erainc.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] percpu-refcount, aio: use percpu_ref_cancel_init()
 in ioctx_alloc()

Hello, Benjamin.

On Wed, Jun 25, 2014 at 10:31:12AM -0400, Benjamin LaHaise wrote:
> On Tue, Jun 17, 2014 at 09:08:00PM -0400, Tejun Heo wrote:
> > ioctx_alloc() reaches inside percpu_ref and directly frees
> > ->pcpu_count in its failure path, which is quite gross.  percpu_ref
> > has been providing a proper interface to do this,
> > percpu_ref_cancel_init(), for quite some time now.  Let's use that
> > instead.
> 
> I applied this to my aio-next tree at git://git.kvack.org/~bcrl/aio-next.git .

It'd probably easier if I route this through percpu tree with the rest
of changes as there are further changes on the aio side (trivial but
still), so we'd end up having to do pulling dance back and forth.  The
changes on aio side are mostly trivial.  Can I route them through
percpu tree with your acks?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/