linux-kernel - Re: [PATCH] blk-mq: run hw queue asynchronously in blk_mq_start_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53AA3B6B.1040103@kernel.dk>
Date:	Tue, 24 Jun 2014 21:00:59 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lei <tom.leiming@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] blk-mq: run hw queue asynchronously in blk_mq_start_hw_queues

On 2014-06-24 20:42, Ming Lei wrote:
> On Tue, Jun 24, 2014 at 10:53 PM, Ming Lei <tom.leiming@...il.com> wrote:
>>  From API view, it isn't good to run all hw queues synchronously
>> in one context, since it isn't correct for multi hw queue case.
>>
>> So this patch adds 'async' parameter to blk_mq_start_hw_queue(),
>> and make blk_mq_start_hw_queues() to run hw queues asynchronously
>> at default.
>
> BTW, without the change, it is easy to trigger the WARN_ON() in
> __blk_mq_run_hw_queue().

Why not just have it call blk_mq_run_hw_queue()? Pass in async == false, 
but let the cpumask logic sort out if we need to force an async run.

-- 
Jens Axboe


View attachment "start.patch" of type "text/x-patch" (400 bytes)