linux-kernel - Re: [PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53AB1140.7070904@collabora.co.uk>
Date:	Wed, 25 Jun 2014 20:13:20 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Doug Anderson <dianders@...omium.org>
CC:	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nel.org>,
	Mike Turquette <mturquette@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Olof Johansson <olof@...om.net>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Daniel Stone <daniels@...labora.com>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks
 binding

Hello Doug,

Thanks a lot for your feedback.

On 06/25/2014 08:06 PM, Doug Anderson wrote:
> Javier,
> 
> On Thu, Jun 19, 2014 at 11:20 AM, Javier Martinez Canillas
> <javier.martinez@...labora.co.uk> wrote:
>> @@ -33,6 +38,6 @@ Example: Clock consumer node
>>         foo@0 {
>>                 compatible = "bar,foo";
>>                 /* ... */
>> -               clock-names = "my-clock";
>> -               clocks = <&max77686 2>;
>> +               clock-names = "32khz_pmic";
>> +               clocks = <&max77686 MAX77686_CLK_PMIC>;
> 
> A minor comment here is that you probably shouldn't change "clock-names".
> 
> The "clock-names" is the consumer's concept of the clock name and not
> the producer's concept.  If this clock were specified as going into
> the TPM, for instance, the TPM might call it "32k-reference".  Then
> the TPM would get the clock by referring to this name in its driver.
> 
> -Doug
> 

You're right. I won't change the clock names in the next version of the patch-set.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/