linux-kernel - [PATCH] RFC: perf: Make overflow signals inheritable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1403727129-20665-1-git-send-email-cov@codeaurora.org>
Date:	Wed, 25 Jun 2014 16:12:09 -0400
From:	Christopher Covington <cov@...eaurora.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org
Cc:	Christopher Covington <cov@...eaurora.org>
Subject: [PATCH] RFC: perf: Make overflow signals inheritable

In order to get a signal from the perf events framework (use an
"event_limit"), one must not not only call perf_event_open() with the
appropriate sample_period, watermark, and wakeup_watermark values,
but also set the FASYNC flag on the resulting file descriptor with
fcntl(). If the inherit attribute is also set, one would expect child
tasks to cause signals like their parents. They don't, though,
because their FASYNC setting isn't set (and can't be by the user
since only the parent has a file descriptor). To fix this, allow the
parent's FASYNC value to be passed along to child events when the
inherit attribute is set. Overflow counts are still per process and
per CPU.

Signed-off-by: Christopher Covington <cov@...eaurora.org>
---
 kernel/events/core.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index a33d9a2b..e6c03c6 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -5440,11 +5440,6 @@ static int __perf_event_overflow(struct perf_event *event,
 			perf_adjust_period(event, delta, hwc->last_period, true);
 	}
 
-	/*
-	 * XXX event_limit might not quite work as expected on inherited
-	 * events
-	 */
-
 	event->pending_kill = POLL_IN;
 	if (events && atomic_dec_and_test(&event->event_limit)) {
 		ret = 1;
@@ -7688,6 +7683,13 @@ inherit_event(struct perf_event *parent_event,
 		= parent_event->overflow_handler_context;
 
 	/*
+	 * To ensure that event_limit works at least a little on inherited
+	 * events, have the child inherit the parent's fasync setting. Note
+	 * that counts are still per process, per CPU.
+	 */
+	child_event->fasync = parent_event->fasync;
+
+	/*
 	 * Precalculate sample_data sizes
 	 */
 	perf_event__header_size(child_event);
-- 
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by the Linux Foundation.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/