linux-kernel - Re: [PATCH] tools: msgque improve error handling when not running as root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <53AB2DE4.8030804@samsung.com>
Date:	Wed, 25 Jun 2014 14:15:32 -0600
From:	Shuah Khan <shuah.kh@...sung.com>
To:	Davidlohr Bueso <davidlohr@...com>
Cc:	gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
	colin.king@...onical.com, linux-kernel@...r.kernel.org,
	Shuah Khan <shuah.kh@...sung.com>
Subject: Re: [PATCH] tools: msgque improve error handling when not running as
 root

On 06/25/2014 02:05 PM, Davidlohr Bueso wrote:
> On Wed, 2014-06-25 at 13:40 -0600, Shuah Khan wrote:
>> The test fails in the middle when it is not run as root while
>> accessing /proc/sys/kernel/msg_next_id. Changed it to check
>> for root at the beginning of the test. Also added messages
>> to indicate start and test pass status.
>>
>> Signed-off-by: Shuah Khan <shuah.kh@...sung.com>
>> ---
>>   tools/testing/selftests/ipc/msgque.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
>> index aa290c0..30c627a 100644
>> --- a/tools/testing/selftests/ipc/msgque.c
>> +++ b/tools/testing/selftests/ipc/msgque.c
>> @@ -193,6 +193,12 @@ int main(int argc, char **argv)
>>   	int msg, pid, err;
>>   	struct msgque_data msgque;
>>
>> +	if (getuid() != 0) {
>> +		fprintf(stderr, "Please run the test as root - Exiting.\n");
>> +		exit(1);
>> +	}
>
> Please use err(3).

I will make this printf to be consistent with the rest of the
printfs in this file.

>
>> +	printf("Starting ipc tests:\n");
>
> This is unnecessary and adds nothing to the program.

The reason for doing this is it becomes easier to parse when this test
is run as part of run_tests at the top level:

make -C tools/testing/selftests run_tests

-- Shuah

-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@...sung.com | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/