linux-kernel - Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53AC086B.80406@linaro.org>
Date:	Thu, 26 Jun 2014 12:47:55 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	Maxime Coquelin <maxime.coquelin@...com>
CC:	devicetree@...r.kernel.org, kernel@...inux.com,
	Linus Walleij <linus.walleij@...aro.org>,
	Patrice Chotard <patrice.chotard@...com>,
	linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less
 than zero



On 26/06/14 12:32, Rickard Strandqvist wrote:
> Remove checking if a unsigned is less than zero
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>   drivers/pinctrl/pinctrl-st.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..f4ee1b1 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct device_node *np,
>   	func = &info->functions[index];
>   	func->name = np->name;
>   	func->ngroups = of_get_child_count(np);
> -	if (func->ngroups <= 0) {
> +	if (func->ngroups == 0) {

Makes sense

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>


>   		dev_err(info->dev, "No groups defined\n");
>   		return -EINVAL;
>   	}
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/