linux-kernel - Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53AC0C22.9010108@st.com>
Date:	Thu, 26 Jun 2014 14:03:46 +0200
From:	Maxime Coquelin <maxime.coquelin@...com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>
Cc:	Patrice Chotard <patrice.chotard@...com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <kernel@...inux.com>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: pinctrl-st.c:  Cleaning up if unsigned is less
 than zero

Hi Rickard,

On 06/26/2014 01:32 PM, Rickard Strandqvist wrote:
> Remove checking if a unsigned is less than zero
> 
> This was found using a static code analysis program called
> cppcheck.
> 
> Signed-off-by: Rickard Strandqvist
> <rickard_strandqvist@...ctrumdigital.se>

You can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@...com>

Thanks,
Maxime
> --- drivers/pinctrl/pinctrl-st.c |    2 +- 1 file changed, 1
> insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c
> b/drivers/pinctrl/pinctrl-st.c index 1bd6363bc9..f4ee1b1 100644 ---
> a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c 
> @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct
> device_node *np, func = &info->functions[index]; func->name =
> np->name; func->ngroups = of_get_child_count(np); -	if
> (func->ngroups <= 0) { +	if (func->ngroups == 0) { 
> dev_err(info->dev, "No groups defined\n"); return -EINVAL; }
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/