[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1403741362.28663.12.camel@joe-AO725>
Date: Wed, 25 Jun 2014 17:09:22 -0700
From: Joe Perches <joe@...ches.com>
To: Cheng-Wei Lee <lee.rhapsody@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sherif Shehab Aldin <shehabaldin.sherif@...il.com>,
Avinash Kumar <avi.kp.137@...il.com>,
Peter Senna Tschudin <peter.senna@...il.com>,
devel <devel@...verdev.osuosl.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: remove return
statements for void function
On Wed, 2014-06-25 at 23:35 +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: Missing a blank line after declarations
Still has a mismatch between subject and code
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
[]
> @@ -3533,7 +3533,7 @@ static void hfa384x_usbin_rx(wlandevice_t
> *wlandev, struct sk_buff *skb)
> }
>
> done:
> - return;
> + pr_debug("hfa384x_usbin_rx: done\n");
I suggest you just leave the return,
Any checkpatch suggestion this was needed was a false
positive that should be resolved by this patch:
http://article.gmane.org/gmane.linux.kernel/1728891
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists