linux-kernel - Re: [PATCH v2 0/2] block,scsi: fixup blk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x49egyaef5s.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 27 Jun 2014 07:59:59 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Joe Lawrence <joe.lawrence@...atus.com>
Cc:	Jens Axboe <axboe@...nel.dk>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios

Joe Lawrence <joe.lawrence@...atus.com> writes:

> On Thu, 26 Jun 2014, Jeff Moyer wrote:
>> Thanks, Jens.  Joe, the patches don't apply anymore... would you mind
>> sending an updated set so Jens doesn't have to do the fixups?  I think
>> you also need to convert blk_mq_alloc_request, I didn't see that in your
>> patch.
>
> Hi Jeff,
>
> I have a new set that applies on top of 3.16-rc2... but before posting, I 
> wasn't sure what needs to be converted w/regard to blk_mq_alloc_request.  
> As far as I can tell, the new multi-queue block IO queueing implementation 
> via blk_mq_alloc_request should be safe from this bug as it doesn't 
> include any dead queue checks that introduce early exits.

Hi, Joe,

blk_mq_alloc_request will return NULL if blk_mq_queue_enter() returns
non-zero.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/