linux-kernel - Re: [PATCH v2 0/2] block,scsi: fixup blk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1406262319140.16358@jlaw-desktop.mno.stratus.com>
Date:	Thu, 26 Jun 2014 23:23:29 -0400
From:	Joe Lawrence <joe.lawrence@...atus.com>
To:	Jeff Moyer <jmoyer@...hat.com>
CC:	Jens Axboe <axboe@...nel.dk>,
	Joe Lawrence <joe.lawrence@...atus.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue
 scenarios

On Thu, 26 Jun 2014, Jeff Moyer wrote:

> Jens Axboe <axboe@...nel.dk> writes:
> 
> > On 2014-06-26 10:08, Jeff Moyer wrote:
> >> Joe Lawrence <joe.lawrence@...atus.com> writes:
> >>
> >>> v1->v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by
> >>>          tags.
> >>>
> >>> Joe Lawrence (2):
> >>>    block,scsi: verify return pointer from blk_get_request
> >>>    block,scsi: convert and handle ERR_PTR from blk_get_request
> >>
> >> Jens,
> >>
> >> Can you pick this series up?  It actually fixes a NULL pointer
> >> dereference that can happen if (for example) a usb optical drive is
> >> removed while an application is using it.
> >
> > Yeah I'll pick it up, opening up the 3.17 branches soon.
> 
> Thanks, Jens.  Joe, the patches don't apply anymore... would you mind
> sending an updated set so Jens doesn't have to do the fixups?  I think
> you also need to convert blk_mq_alloc_request, I didn't see that in your
> patch.

Hi Jeff,

I have a new set that applies on top of 3.16-rc2... but before posting, I 
wasn't sure what needs to be converted w/regard to blk_mq_alloc_request.  
As far as I can tell, the new multi-queue block IO queueing implementation 
via blk_mq_alloc_request should be safe from this bug as it doesn't 
include any dead queue checks that introduce early exits.

Regards,

-- Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/