linux-kernel - Re: [PATCH] tools: selftests - create a separate hotplug target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140627130411.d351b6543787b826f5ba1b34@linux-foundation.org>
Date:	Fri, 27 Jun 2014 13:04:11 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	shuah.kh@...sung.com
Cc:	gregkh@...uxfoundation.org, keescook@...omium.org,
	michael@...erman.id.au, fweisbec@...il.com,
	benh@...nel.crashing.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools: selftests - create a separate hotplug target

On Fri, 27 Jun 2014 13:59:55 -0600 Shuah Khan <shuah.kh@...sung.com> wrote:

> > I don't know really.  You know more about this than I - what advantages
> > does the separate-make-target approach have over this approach?
> >
> 
> Currently these tests run with full range - i.e try to offline
> all cpus that are hotpluggable and try to offline all memory
> that is hotpluggable. This results in hangs.
> 
> Creating a separate target the way I did it in this patch excludes these
> tests all together. i.e when somebody runs:
> 
> make -C tools/testing/selftests run_tests
> 
> hotplug tests don't run.
> 
> Instead, with a few changes, tests can be run with a reduced scope so
> a % of the memory gets offlined as opposed to all of it and the same
> thing with cpus. This way hotplug code gets tested as opposed to
> being excluded in a default test run case.
> 
> However, if limited scope testing isn't useful, separate target is
> better until tests can be made safe to run without hangs.

hm, OK.  So it sounds like the best solution would be to run the
limited tests by default and to require special intervention to run the
full tests.

I guess a separate make target is a suitable way of running the full
tests.  We could use an environment variable or various other things.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/