linux-kernel - Re: [PATCH] trace-cmd: handle NULL comm name in .dat file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140627162123.3f9be953@gandalf.local.home>
Date:	Fri, 27 Jun 2014 16:21:23 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Josef Bacik <jbacik@...com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] trace-cmd: handle NULL comm name in .dat file

On Thu, 26 Jun 2014 09:22:12 -0700
Josef Bacik <jbacik@...com> wrote:

> Sometimes the comm field in the trace.dat file can be empty which means that the
> event parsing stuff can pass a NULL into pevent_register_comm.  To fix this just
> check if we are NULL and generate a bogus comm name for that PID.  This keeps us
> from segfaulting.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@...com>

Applied, thanks!

-- Steve

> ---
>  event-parse.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/event-parse.c b/event-parse.c
> index 18b3587..00304fe 100644
> --- a/event-parse.c
> +++ b/event-parse.c
> @@ -303,7 +303,10 @@ int pevent_register_comm(struct pevent *pevent, const char *comm, int pid)
>  	if (!item)
>  		return -1;
>  
> -	item->comm = strdup(comm);
> +	if (comm)
> +		item->comm = strdup(comm);
> +	else
> +		item->comm = strdup("<...>");
>  	if (!item->comm) {
>  		free(item);
>  		return -1;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/