[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140628023718.GB3579@kroah.com>
Date: Fri, 27 Jun 2014 22:37:18 -0400
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Guillaume Morin <guillaume@...infr.org>,
Jonathan Cameron <jic23@...nel.org>,
Sachin Kamat <sachin.kamat@...aro.org>,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error
On Sat, Jun 28, 2014 at 04:30:09AM +0200, Guillaume Morin wrote:
> On 27 Jun 19:09, Greg Kroah-Hartman wrote:
> > > v2: add missing Signed-off-by
> >
> > That doesn't go here.
>
> I guess I am struggling to get git send-email do what I want
Put that below the --- line.
> > And what checkpatch error did you fix? And are you sure it needs to be
> > fixed?
>
> That's what I changed:
>
> $ scripts/checkpatch.pl -f drivers/staging/iio/frequency/ad9850.c
> ERROR: Macros with complex values should be enclosed in parenthesis
Then why didn't you say that :)
> I assumed that if it was reported as an error, it needed to be fixed...
Use your judgement, checkpatch is a tool, it isn't always correct.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists