| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140628031045.GA13985@bender.morinfr.org> Date: Sat, 28 Jun 2014 05:10:46 +0200 From: Guillaume Morin <guillaume@...infr.org> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Guillaume Morin <guillaume@...infr.org>, Jonathan Cameron <jic23@...nel.org>, Sachin Kamat <sachin.kamat@...aro.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error On 27 Jun 22:37, Greg Kroah-Hartman wrote: > Put that below the --- line. Will do. > > > And what checkpatch error did you fix? And are you sure it needs to be > > > fixed? > > > > That's what I changed: > > > > $ scripts/checkpatch.pl -f drivers/staging/iio/frequency/ad9850.c > > ERROR: Macros with complex values should be enclosed in parenthesis > > Then why didn't you say that :) Well it was not totally clear to me if that was obvious or not. Anyway, I'll mention it in the future. > > > I assumed that if it was reported as an error, it needed to be fixed... > > Use your judgement, checkpatch is a tool, it isn't always correct. Right, I guess it's borderline. Should I resend the patch or just drop it? Guillaume. -- Guillaume Morin <guillaume@...infr.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists