linux-kernel - Re: [PATCH] usb: usb3503: return correct error return on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <00a401cf93ff$2f0b7fa0$8d227ee0$%han@samsung.com>
Date:	Mon, 30 Jun 2014 10:04:03 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Colin King' <colin.king@...onical.com>,
	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, 'Mark Brown' <broonie@...aro.org>,
	linux-usb@...r.kernel.org, 'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] usb: usb3503: return correct error return on failure

On Monday, June 30, 2014 6:43 AM, Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> Fix warning: drivers/usb/misc/usb3503.c:195:11: warning: 'err'
>   may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> err is not initialized, the error return should be PTR_ERR(clk)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

It looks good!

Reviewed-by: Jingoo Han <jg1.han@...sung.com>

Best regards,
Jingoo Han

> ---
>  drivers/usb/misc/usb3503.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
> index f43c619..c0c898d 100644
> --- a/drivers/usb/misc/usb3503.c
> +++ b/drivers/usb/misc/usb3503.c
> @@ -192,7 +192,8 @@ static int usb3503_probe(struct usb3503 *hub)
> 
>  		clk = devm_clk_get(dev, "refclk");
>  		if (IS_ERR(clk) && PTR_ERR(clk) != -ENOENT) {
> -			dev_err(dev, "unable to request refclk (%d)\n", err);
> +			dev_err(dev, "unable to request refclk (%ld)\n",
> +				PTR_ERR(clk));
>  			return PTR_ERR(clk);
>  		}
> 
> --
> 2.0.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/