linux-kernel - Re: [PATCH] KVM: x86: Fix lapic.c debug prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53B0B773.3030107@gmail.com>
Date:	Mon, 30 Jun 2014 04:03:47 +0300
From:	Nadav Amit <nadav.amit@...il.com>
To:	Bandan Das <bsd@...hat.com>, Nadav Amit <namit@...technion.ac.il>
CC:	pbonzini@...hat.com, gleb@...nel.org, tglx@...utronix.de,
	mingo@...hat.com, x86@...nel.org, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix lapic.c debug prints

On 6/30/14, 3:48 AM, Bandan Das wrote:
> Nadav Amit <namit@...technion.ac.il> writes:
>
>> In two cases lapic.c does not use the apic_debug macro correctly. This patch
>> fixes them.
>>
>> Signed-off-by: Nadav Amit <namit@...technion.ac.il>
>> ---
>>   arch/x86/kvm/lapic.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
>> index 0069118..3855103 100644
>> --- a/arch/x86/kvm/lapic.c
>> +++ b/arch/x86/kvm/lapic.c
>> @@ -1451,7 +1451,7 @@ void kvm_lapic_reset(struct kvm_vcpu *vcpu)
>>   	vcpu->arch.apic_arb_prio = 0;
>>   	vcpu->arch.apic_attention = 0;
>>
>> -	apic_debug(KERN_INFO "%s: vcpu=%p, id=%d, base_msr="
>> +	apic_debug("%s: vcpu=%p, id=%d, base_msr="
>>   		   "0x%016" PRIx64 ", base_address=0x%0lx.\n", __func__,
>>   		   vcpu, kvm_apic_id(apic),
>>   		   vcpu->arch.apic_base, apic->base_address);
>> @@ -1895,7 +1895,7 @@ void kvm_apic_accept_events(struct kvm_vcpu *vcpu)
>>   		/* evaluate pending_events before reading the vector */
>>   		smp_rmb();
>>   		sipi_vector = apic->sipi_vector;
>> -		pr_debug("vcpu %d received sipi with vector # %x\n",
>> +		apic_debug("vcpu %d received sipi with vector # %x\n",
>
> Why don't we just use pr_debug all throughout ?
>
I don't know. I just tried to make it consistent, since it really bugged 
me while I was debugging the local-apic.
If you prefer the other way around (which does seem to be better), I can 
do the search-and-replace.

Nadav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/