linux-kernel - Re: [PATCH 1/2] bq27x00 - don't report power-supply change so often.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 30 Jun 2014 21:52:52 +0200
From:	Belisko Marek <marek.belisko@...il.com>
To:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Sebastian Reichel <sre@...nel.org>
Cc:	"Dr. H. Nikolaus Schaller" <hns@...delico.com>,
	Marek Belisko <marek@...delico.com>, NeilBrown <neilb@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] bq27x00 - don't report power-supply change so often.

Sorry forgot to CC lkml. CCing now.

On Mon, Jun 30, 2014 at 9:49 PM, Marek Belisko <marek@...delico.com> wrote:
> From: NeilBrown <neilb@...e.de>
>
> A power_supply_changed should only be reported on significant changes
> such as transition between charging and not.  Incremental changes
> such as charge increasing should not be reported - that can easily
> be polled for.
>
> Signed-off-by: NeilBrown <neilb@...e.de>
> ---
>  drivers/power/bq27x00_battery.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index b309713..27bac1d 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -62,6 +62,8 @@
>  #define BQ27000_FLAG_FC                        BIT(5)
>  #define BQ27000_FLAG_CHGS              BIT(7) /* Charge state flag */
>
> +#define BQ27000_FLAGS_IMPORTANT                (BQ27000_FLAG_FC|BQ27000_FLAG_CHGS|BIT(31))
> +
>  #define BQ27500_REG_SOC                        0x2C
>  #define BQ27500_REG_DCAP               0x3C /* Design capacity */
>  #define BQ27500_FLAG_DSC               BIT(0)
> @@ -74,6 +76,8 @@
>  #define BQ27425_REG_OFFSET             0x04
>  #define BQ27425_REG_SOC                        0x18 /* Register address plus offset */
>
> +#define BQ27500_FLAGS_IMPORTANT                (BQ27500_FLAG_FC|BQ27500_FLAG_DSC|BIT(31))
> +
>  #define BQ27000_RS                     20 /* Resistor sense */
>  #define BQ27x00_POWER_CONSTANT         (256 * 29200 / 1000)
>
> @@ -413,6 +417,7 @@ static void bq27x00_update(struct bq27x00_device_info *di)
>         struct bq27x00_reg_cache cache = {0, };
>         bool is_bq27500 = di->chip == BQ27500;
>         bool is_bq27425 = di->chip == BQ27425;
> +       int flags_changed;
>
>         cache.flags = bq27x00_read(di, BQ27x00_REG_FLAGS, !is_bq27500);
>         if (cache.flags >= 0) {
> @@ -454,10 +459,14 @@ static void bq27x00_update(struct bq27x00_device_info *di)
>                         di->charge_design_full = bq27x00_battery_read_ilmd(di);
>         }
>
> -       if (memcmp(&di->cache, &cache, sizeof(cache)) != 0) {
> -               di->cache = cache;
> +       flags_changed = di->cache.flags ^ cache.flags;
> +       di->cache = cache;
> +       if (is_bq27500)
> +               flags_changed &= BQ27500_FLAGS_IMPORTANT;
> +       else
> +               flags_changed &= BQ27000_FLAGS_IMPORTANT;
> +       if (flags_changed)
>                 power_supply_changed(&di->bat);
> -       }
>
>         di->last_update = jiffies;
>  }
> --
> 1.9.1
>



-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/