linux-kernel - Re: [PATCH 2/2] bq27000: report missing device better.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAAfyv34tGM6ThBfk+0XcGD+4SKbN5w_AA9EUWMBXe7z7qhjSfw@mail.gmail.com>
Date:	Mon, 30 Jun 2014 21:53:24 +0200
From:	Belisko Marek <marek.belisko@...il.com>
To:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Sebastian Reichel <sre@...nel.org>
Cc:	"Dr. H. Nikolaus Schaller" <hns@...delico.com>,
	Marek Belisko <marek@...delico.com>, NeilBrown <neilb@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] bq27000: report missing device better.

CCing lkml

On Mon, Jun 30, 2014 at 9:49 PM, Marek Belisko <marek@...delico.com> wrote:
> One an hdq buss, a missing device reads as 0xff, not -1.
> So do a translation to allow detecting of a missing bus.
>
> Signed-off-by: NeilBrown <neilb@...e.de>
> ---
>  drivers/power/bq27x00_battery.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index 27bac1d..aa80efc 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -420,6 +420,9 @@ static void bq27x00_update(struct bq27x00_device_info *di)
>         int flags_changed;
>
>         cache.flags = bq27x00_read(di, BQ27x00_REG_FLAGS, !is_bq27500);
> +       if ((cache.flags & 0xff) == 0xff)
> +               /* read error */
> +               cache.flags = -1;
>         if (cache.flags >= 0) {
>                 if (!is_bq27500 && !is_bq27425
>                                 && (cache.flags & BQ27000_FLAG_CI)) {
> --
> 1.9.1
>



-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/