linux-kernel - Re: [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140630214342.GI23300@sirena.org.uk>
Date:	Mon, 30 Jun 2014 22:43:42 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Mark Rutland <mark.rutland@....com>
Cc:	Dan Murphy <dmurphy@...com>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier

On Mon, Jun 30, 2014 at 06:21:15PM +0100, Mark Rutland wrote:
> On Mon, Jun 30, 2014 at 06:10:59PM +0100, Dan Murphy wrote:

> > +Optional properties:

> > +- power-gpio - gpio pin to enable/disable the device

> The code below seems to look for "enable-gpio". Searching for
> "power-gpio" only hits in the line above and the example below. I assume
> the code is in error?

It depends what this is for - if it's for an external regulator it
should be a regulator binding.  Also all GPIO properties
are supposed to be called -gpios because DT conventions.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)