linux-kernel - Re: [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140701083749.GH28740@leverpostej>
Date:	Tue, 1 Jul 2014 09:37:49 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Dan Murphy <dmurphy@...com>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier

On Mon, Jun 30, 2014 at 10:43:42PM +0100, Mark Brown wrote:
> On Mon, Jun 30, 2014 at 06:21:15PM +0100, Mark Rutland wrote:
> > On Mon, Jun 30, 2014 at 06:10:59PM +0100, Dan Murphy wrote:
> 
> > > +Optional properties:
> 
> > > +- power-gpio - gpio pin to enable/disable the device
> 
> > The code below seems to look for "enable-gpio". Searching for
> > "power-gpio" only hits in the line above and the example below. I assume
> > the code is in error?
> 
> It depends what this is for - if it's for an external regulator it
> should be a regulator binding.  Also all GPIO properties
> are supposed to be called -gpios because DT conventions.

Sure. I was commenting on the mismatch between "enable" in the code and
"power" in the documentation rather than the appropriateness of either
"power-gpios" or "enable-gpios".

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/