| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140630215938.GR10819@suse.de> Date: Mon, 30 Jun 2014 22:59:38 +0100 From: Mel Gorman <mgorman@...e.de> To: Hugh Dickins <hughd@...gle.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] mm: replace init_page_accessed by __SetPageReferenced On Mon, Jun 30, 2014 at 02:09:49PM -0700, Hugh Dickins wrote: > Do we really need an exported alias for __SetPageReferenced()? > Its callers better know what they're doing, in which case the page > would not be already marked referenced. Kill init_page_accessed(), > just __SetPageReferenced() inline. > > Signed-off-by: Hugh Dickins <hughd@...gle.com> Ok, fair enough. The context it was written in was that callers should not need to know the internals of what mark_page_accessed does. Initially I thought there might be filesystem users that really should not know the internals but that is not necessary obviously. I still feel that init_page_accessed shows the intent more clearly and you're certainly right that the checking PageReferenced is redundant. I don't object to the patch but I don't think it's obviously better either other than it avoids the temptation of anyone using __SetPageReferenced incorrectly. Acked-by: Mel Gorman <mgorman@...e.de> -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists