linux-kernel - Re: [PATCH] x86: ioapic: Fix irq_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1406301452060.13545@chino.kir.corp.google.com>
Date:	Mon, 30 Jun 2014 14:57:52 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Keith Busch <keith.busch@...el.com>
cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	x86@...nel.org
Subject: Re: [PATCH] x86: ioapic: Fix irq_free_descs count

On Mon, 30 Jun 2014, Keith Busch wrote:

> Signed-off-by: Keith Busch <keith.busch@...el.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: x86@...nel.org

Acked-by: David Rientjes <rientjes@...gle.com>

This is definitely a fix for "genirq: Provide generic hwirq allocation 
facility", but the changelog doesn't describe what the problem is and the 
title that this somehow fixes irq_free_descs() doesn't make any sense.

It's the equivalent of just doing

-	irq_free_descs(from, cnt);
+	irq_free_descs(from, i - from);

I'd suggest the patch title be changed to

	genirq: Fix memory leak when calling irq_free_hwirqs()

and the changelog state

irq_free_hwirqs() always calls irq_free_descs() with a cnt == 0 which 
makes it a no-op since the interrupt count to free is decremented in 
itself.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/